Differential D11981

Share code for context link rendering on side-by-side diffs
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 4:42 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity

Commits

Restricted Diffusion Commit
rPcb886eb60eed: Share code for context link rendering on side-by-side diffs

Summary

Ref T2009. I've clicked these links like 200 times in testing now, so I'm feeling pretty good about them.

Test Plan

Viewed links in side-by-side diff, clicked them.

Diff Detail

Repository

rP Phabricator

Branch

uni9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4761
Build 4777: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28833.Mar 5 2015, 4:42 PM

epriestley retitled this revision from to Share code for context link rendering on side-by-side diffs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 4:42 PM

btrahan accepted this revision.Mar 5 2015, 8:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2015, 8:59 PM

Closed by commit rPcb886eb60eed: Share code for context link rendering on side-by-side diffs (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

64 lines

Diff 28833

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Share code for context link rendering on side-by-side diffsClosedPublicActions