Differential D11973

Improve display of "Context not available" in 1-up view
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 1:38 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity

Commits

Restricted Diffusion Commit
rP17702f398424: Improve display of "Context not available" in 1-up view

Summary

Ref T2009. Makes "Context not available" render and behave correctly.

Test Plan

Viewed diff with missing context in 1-up view, looked marginally better.

Diff Detail

Repository

rP Phabricator

Branch

uni2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4752
Build 4768: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28824.Mar 5 2015, 1:38 AM

epriestley retitled this revision from to Improve display of "Context not available" in 1-up view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 1:38 AM

btrahan accepted this revision.Mar 5 2015, 8:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2015, 8:44 PM

Closed by commit rP17702f398424: Improve display of "Context not available" in 1-up view (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2015, 10:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

5 lines

Diff 28824

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Improve display of "Context not available" in 1-up viewClosedPublicActions