Page MenuHomePhabricator
Differential D11964

Set "importing" flag on repositories created via API
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 12:53 PM.
Tags
None
Referenced Files
F13206630: D11964.id.diff
Wed, May 15, 1:58 PM
F13206629: D11964.id28813.diff
Wed, May 15, 1:58 PM
F13206628: D11964.id28805.diff
Wed, May 15, 1:58 PM
F13180866: D11964.diff
Thu, May 9, 4:41 AM
Unknown Object (File)
Tue, May 7, 7:07 AM
Unknown Object (File)
Mon, May 6, 1:15 PM
Unknown Object (File)
Fri, May 3, 5:13 AM
Unknown Object (File)
Thu, Apr 25, 12:48 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages
Commits
Restricted Diffusion Commit
rP027d4ffd8bae: Set "importing" flag on repositories created via API
Summary

Ref T6516. We incorrectly fail to set this flag on repositories created via Conduit, which activates too many actions on old commits.

Test Plan
  • Created a new repository via Conduit, verified it was "importing" after creation.
  • Created a new repostiory via web UI, verified it was "importing" after creation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28805.Mar 4 2015, 12:53 PM
epriestley retitled this revision from to Set "importing" flag on repositories created via API.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages .
Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 12:53 PM
epriestley added inline comments.Mar 4 2015, 12:54 PM
src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
19

The "Admin Only" text was no longer accurate.

66–69

Specifically, these policy controls now govern access.

epriestley mentioned this in T6887: Emails sent for historical commits when importing repo to Diffusion.Mar 4 2015, 2:27 PM
btrahan accepted this revision.Mar 4 2015, 6:26 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2015, 6:26 PM
Closed by commit rP027d4ffd8bae: Set "importing" flag on repositories created via API (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
4 lines
repository/
conduit/
4 lines
storage/
8 lines

Diff 28813

View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Loading...
View Options

src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility