Page MenuHomePhabricator

D11964.id28813.diff
No OneTemporary

D11964.id28813.diff

diff --git a/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php b/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
@@ -152,10 +152,6 @@
// transactions to apply this change.
$repository->setCallsign($callsign);
- // Put the repository in "Importing" mode until we finish
- // parsing it.
- $repository->setDetail('importing', true);
-
$xactions[] = id(clone $template)
->setTransactionType($type_name)
->setNewValue(
diff --git a/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php b/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
--- a/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
+++ b/src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php
@@ -16,7 +16,7 @@
}
public function getMethodDescription() {
- return 'Create a new repository (Admin Only).';
+ return pht('Create a new repository.');
}
public function defineParamTypes() {
@@ -48,8 +48,6 @@
public function defineErrorTypes() {
return array(
- 'ERR-PERMISSIONS' =>
- 'You do not have the authority to call this method.',
'ERR-DUPLICATE' =>
'Duplicate repository callsign.',
'ERR-BAD-CALLSIGN' =>
diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -69,10 +69,16 @@
$edit_policy = $app->getPolicy(DiffusionDefaultEditCapability::CAPABILITY);
$push_policy = $app->getPolicy(DiffusionDefaultPushCapability::CAPABILITY);
- return id(new PhabricatorRepository())
+ $repository = id(new PhabricatorRepository())
->setViewPolicy($view_policy)
->setEditPolicy($edit_policy)
->setPushPolicy($push_policy);
+
+ // Put the repository in "Importing" mode until we finish
+ // parsing it.
+ $repository->setDetail('importing', true);
+
+ return $repository;
}
protected function getConfiguration() {

File Metadata

Mime Type
text/plain
Expires
Thu, May 16, 1:58 PM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6281593
Default Alt Text
D11964.id28813.diff (2 KB)

Event Timeline