Differential D11965

Include custom header PHID in header logo cache key
ClosedPublic
Actions

Authored by epriestley on Mar 4 2015, 12:58 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4214: Allow installs to change or supplement the "Phabricator" icon

Commits

Restricted Diffusion Commit
rP46e5e79c4f08: Include custom header PHID in header logo cache key

Summary

Ref T4214. Reduce the need for installs to purge caches.

Test Plan

Screen_Shot_2015-03-04_at_4.57.26_AM.png (1×1 px, 134 KB)

Changed header twice.
New one showed up without dirtying cache.

Diff Detail

Repository

rP Phabricator

Branch

cachekey

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4743
Build 4757: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28806.Mar 4 2015, 12:58 PM

epriestley retitled this revision from to Include custom header PHID in header logo cache key.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 4 2015, 12:59 PM

btrahan accepted this revision.Mar 4 2015, 6:26 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 4 2015, 6:26 PM

Closed by commit rP46e5e79c4f08: Include custom header PHID in header logo cache key (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2015, 6:36 PM

This revision was automatically updated to reflect the committed changes.

• wasimsikder removed a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:00 AM

avivey added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:43 AM

Revision Contents
Changeset List

Path

Size

src/

view/

page/

menu/

PhabricatorMainMenuView.php

2 lines

Diff 28806

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Include custom header PHID in header logo cache keyClosedPublicActions