Differential D11937

Improve exception when creating a cyclic dependency in Maniphest
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 11:02 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog

Commits

Restricted Diffusion Commit
rPe65116987978: Improve exception when creating a cyclic dependency in Maniphest

Summary

Fixes T6815. This was overlooked in D9838. This could be prettier, but does the job.

Test Plan

Screen_Shot_2015-03-02_at_3.00.28_PM.png (1×1 px, 168 KB)

Diff Detail

Repository

rP Phabricator

Branch

cycle

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4714
Build 4728: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28755.Mar 2 2015, 11:02 PM

epriestley retitled this revision from to Improve exception when creating a cyclic dependency in Maniphest.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 11:02 PM

btrahan accepted this revision.Mar 2 2015, 11:09 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 2 2015, 11:09 PM

Closed by commit rPe65116987978: Improve exception when creating a cyclic dependency in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2015, 12:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorSearchAttachController.php

11 lines

Diff 28755

View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Improve exception when creating a cyclic dependency in ManiphestClosedPublicActions