Page MenuHomePhabricator

Fix a newline issue in "arc" workflows
ClosedPublic

Authored by epriestley on Mar 2 2015, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 11:39 AM
Unknown Object (File)
Mon, Feb 17, 9:35 PM
Unknown Object (File)
Mon, Feb 17, 8:10 PM
Unknown Object (File)
Fri, Feb 14, 10:08 PM
Unknown Object (File)
Jan 27 2025, 2:44 AM
Unknown Object (File)
Jan 27 2025, 2:44 AM
Unknown Object (File)
Jan 27 2025, 2:44 AM
Unknown Object (File)
Jan 27 2025, 2:32 AM
Subscribers

Details

Summary

We end up with one too few newline here in some workflows, like arc land with unstaged changes.

Root issue here is that phutil_console_prompt|confirm lead with too much whitespace but that's a harder fix.

Test Plan

Saw reasonable whitespace.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a newline issue in "arc" workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.