Page MenuHomePhabricator

Fix a newline issue in "arc" workflows
ClosedPublic

Authored by epriestley on Mar 2 2015, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 10:42 PM
Unknown Object (File)
Fri, Dec 13, 8:13 PM
Unknown Object (File)
Fri, Dec 13, 2:51 AM
Unknown Object (File)
Nov 30 2024, 3:40 PM
Unknown Object (File)
Nov 28 2024, 5:01 PM
Unknown Object (File)
Nov 28 2024, 5:01 PM
Unknown Object (File)
Nov 28 2024, 5:01 PM
Unknown Object (File)
Nov 28 2024, 4:47 PM
Subscribers

Details

Summary

We end up with one too few newline here in some workflows, like arc land with unstaged changes.

Root issue here is that phutil_console_prompt|confirm lead with too much whitespace but that's a harder fix.

Test Plan

Saw reasonable whitespace.

Diff Detail

Repository
rARC Arcanist
Branch
ws1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4703
Build 4717: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix a newline issue in "arc" workflows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.