Page MenuHomePhabricator

Improve error messages when specifying bad set or list to bin/config
ClosedPublic

Authored by epriestley on Mar 2 2015, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 3:21 PM
Unknown Object (File)
Thu, Dec 5, 9:52 PM
Unknown Object (File)
Thu, Dec 5, 5:23 AM
Unknown Object (File)
Sun, Dec 1, 6:38 AM
Unknown Object (File)
Wed, Nov 27, 7:46 PM
Unknown Object (File)
Wed, Nov 27, 5:07 PM
Unknown Object (File)
Tue, Nov 26, 7:34 PM
Unknown Object (File)
Nov 23 2024, 8:40 PM
Subscribers

Details

Summary

Fixes T7308. Multiple users have encountered confusion around how they should specify a set or list in JSON; provide examples.

Test Plan
epriestley@orbital ~/dev/phabricator $ ./bin/config set files.image-mime-types true
Usage Exception: Config key 'files.image-mime-types' is of type 'set'. Specify it in JSON. For example:

    ./bin/config set '{"value1": true, "value2": true}'

epriestley@orbital ~/dev/phabricator $ ./bin/config set cluster.addresses true
Usage Exception: Config key 'cluster.addresses' is of type 'list<string>'. Specify it in JSON. For example:

    ./bin/config set '["a", "b", "c"]'

epriestley@orbital ~/dev/phabricator $

Diff Detail

Repository
rP Phabricator
Branch
conf1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4701
Build 4715: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve error messages when specifying bad set or list to bin/config.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2015, 3:04 PM
This revision was automatically updated to reflect the committed changes.