Page MenuHomePhabricator

When redirecting to acquire file access tokens, retain 'download' parameter
ClosedPublic

Authored by epriestley on Mar 1 2015, 3:55 PM.
Tags
None
Referenced Files
F14064428: D11915.diff
Mon, Nov 18, 11:31 PM
F14051659: D11915.diff
Fri, Nov 15, 2:51 AM
F14038440: D11915.diff
Sun, Nov 10, 11:41 PM
F14023948: D11915.diff
Thu, Nov 7, 4:24 AM
F14011499: D11915.id28712.diff
Fri, Nov 1, 2:25 AM
F13987078: D11915.id28703.diff
Oct 21 2024, 7:20 AM
F13982555: D11915.diff
Oct 20 2024, 12:09 AM
F13955067: D11915.id28703.diff
Oct 14 2024, 12:03 AM
Subscribers
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Summary

Fixes T7398. Previously, we would redirect to get a token and then redirect back to make use of it, but lose "download" in the process, and thus not get the correct "Content-Disposition" header.

Test Plan

Clicked "Download" on a lightboxed file.

Diff Detail

Repository
rP Phabricator
Branch
download1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4686
Build 4700: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to When redirecting to acquire file access tokens, retain 'download' parameter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan awarded a token.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2015, 6:42 PM
This revision was automatically updated to reflect the committed changes.