Page MenuHomePhabricator
Differential D11915

When redirecting to acquire file access tokens, retain 'download' parameter
ClosedPublic
Actions

Authored by epriestley on Mar 1 2015, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 9:15 PM
Unknown Object (File)
Fri, Sep 6, 12:46 PM
Unknown Object (File)
Wed, Sep 4, 12:25 PM
Unknown Object (File)
Sun, Sep 1, 4:12 AM
Unknown Object (File)
Fri, Aug 23, 5:03 PM
Unknown Object (File)
Thu, Aug 22, 8:15 AM
Unknown Object (File)
Wed, Aug 21, 7:50 AM
Unknown Object (File)
Mon, Aug 19, 4:50 PM
View All Files
Subscribers
epriestley
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T7398: Clicking "Download" on an image, and then right-click Save Image As does not work
Commits
Restricted Diffusion Commit
rPed49b41e915d: When redirecting to acquire file access tokens, retain 'download' parameter
Summary

Fixes T7398. Previously, we would redirect to get a token and then redirect back to make use of it, but lose "download" in the process, and thus not get the correct "Content-Disposition" header.

Test Plan

Clicked "Download" on a lightboxed file.

Diff Detail

Repository
rP Phabricator
Branch
download1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4686
Build 4700: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28703.Mar 1 2015, 3:55 PM
epriestley retitled this revision from to When redirecting to acquire file access tokens, retain 'download' parameter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7398: Clicking "Download" on an image, and then right-click Save Image As does not work.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 1 2015, 3:55 PM
btrahan accepted this revision.Mar 1 2015, 6:42 PM
btrahan awarded a token.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2015, 6:42 PM
Closed by commit rPed49b41e915d: When redirecting to acquire file access tokens, retain 'download' parameter (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2015, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
controller/
23 lines

Diff 28703

View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
Phabricator · Built by Phacility