Page MenuHomePhabricator
Differential D11910

Re-enable the deprecated calls setup check
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2015, 11:45 AM.
Tags
None
Referenced Files
F15467407: D11910.id29576.diff
Thu, Apr 3, 2:36 PM
F15465342: D11910.id28689.diff
Wed, Apr 2, 5:38 PM
F15464209: D11910.id.diff
Wed, Apr 2, 7:18 AM
F15461850: D11910.diff
Tue, Apr 1, 11:51 AM
F15456798: D11910.diff
Sun, Mar 30, 12:18 PM
F15398767: D11910.id28689.diff
Mon, Mar 17, 1:34 AM
Unknown Object (File)
Mar 2 2025, 10:17 PM
Unknown Object (File)
Feb 26 2025, 3:57 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPec12b710aac0: Re-enable the deprecated calls setup check
Summary

This reverts commit 55c00ebfa125199e4914e98574950e6111a416d7. T7111, T7112 and T7113 have all been resolved now.

Test Plan

Maybe wait a few more weeks... I just wanted to ensure that this wasn't forgotten.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4679
Build 4693: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28689.Feb 28 2015, 11:45 AM
joshuaspence retitled this revision from to Re-enable the deprecated calls setup.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2015, 11:45 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence retitled this revision from Re-enable the deprecated calls setup to Re-enable the deprecated calls setup check.Feb 28 2015, 10:50 PM
joshuaspence edited edge metadata.
joshuaspence added a comment.Apr 5 2015, 10:53 PM

This is maybe okay now?

epriestley accepted this revision.Apr 6 2015, 1:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:31 PM
Closed by commit rPec12b710aac0: Re-enable the deprecated calls setup check (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 7 2015, 8:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conduit/
check/
4 lines

Diff 28689

View Options

src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php

Loading...
Phabricator · Built by Phacility