Paths

Table of Contentst

Differential D11893

Use utf8_general_ci for "sort" columns in old MySQL
ClosedPublic
Actions

Authored by epriestley on Feb 26 2015, 4:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 9:23 PM

	Unknown Object (File)
	Sun, Dec 15, 9:57 AM

	Unknown Object (File)
	Fri, Dec 13, 9:48 PM

	Unknown Object (File)
	Sun, Dec 8, 8:48 AM

	Unknown Object (File)
	Fri, Dec 6, 1:36 PM

	Unknown Object (File)
	Nov 20 2024, 6:38 PM

	Unknown Object (File)
	Nov 15 2024, 11:51 PM

	Unknown Object (File)
	Nov 11 2024, 6:34 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems

Commits

Restricted Diffusion Commit
rP9e82cfcc214b: Use utf8_general_ci for "sort" columns in old MySQL

Summary

Fixes T7287. This trades off 4-byte character support for case insensitivity in these columns, which is a much better trade on the balance.

Also adds more warnings about old MySQL. Note that we already issue a warning when you run "storage adjust" (which I've made stronger) and already "strongly recommend" MySQL 5.5 or newer in the install documentation.

Test Plan

Ran storage adjust --disable-utf8mb4 to go to old definitions, then ran storage adjust to get back to the new ones. Everything seemed OK in both cases.
Verified that utf8mb4 data can be migrated out of these colums with --unsafe (which will truncate).
Verified that manual explains this.
Faked my way into the setup warning.

Diff Detail

Repository

Branch

utf1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4657
Build 4671: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28652.Feb 26 2015, 4:00 PM

epriestley retitled this revision from to Use utf8_general_ci for "sort" columns in old MySQL.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 26 2015, 4:00 PM

btrahan accepted this revision.Feb 26 2015, 6:08 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 26 2015, 6:08 PM

Closed by commit rP9e82cfcc214b: Use utf8_general_ci for "sort" columns in old MySQL (authored by epriestley, committed by epriestley). · Explain WhyFeb 26 2015, 6:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorMySQLSetupCheck.php

20 lines

infrastructure/

storage/

management/

PhabricatorStorageManagementAPI.php

31 lines

workflow/

PhabricatorStorageManagementWorkflow.php

8 lines

Diff 28652

src/applications/config/check/PhabricatorMySQLSetupCheck.php

Loading...

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...