Only SIGINT the daemon itself, not its entire process group
ClosedPublic
Actions

Authored by epriestley on Feb 25 2015, 10:13 PM.

Details

Reviewers

hach-que
btrahan

Commits

rPHU124e5a41e086: Only SIGINT the daemon itself, not its entire process group

Summary

Signaling the process group is correct for SIGTERM and SIGKILL (nongraceful exits) but not for SIGINT (graceful exit). Subprocesses of the daemon may exit abruptly on SIGINT, which is not consistent with the requested behavior ("exit gracefully").

Test Plan

Ran bin/phd start, bin/phd stop.

Diff Detail

Repository

rPHU libphutil

Branch

graceful

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4651
Build 4665: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28644.Feb 25 2015, 10:13 PM

epriestley retitled this revision from to Only SIGINT the daemon itself, not its entire process group.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 25 2015, 10:13 PM

Tested with P1728 and saw the expected behaviour.

This revision is now accepted and ready to land.Feb 25 2015, 10:32 PM

Closed by commit rPHU124e5a41e086: Only SIGINT the daemon itself, not its entire process group (authored by epriestley, committed by epriestley). · Explain WhyFeb 25 2015, 10:36 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7371: `bin/phd stop --graceful` interrupts Harbormaster "Run Command" steps.Feb 26 2015, 12:27 AM

Revision Contents
Changeset List

Path

Size

src/

daemon/

PhutilDaemonHandle.php

13 lines

Diff 28644

View Options

src/daemon/PhutilDaemonHandle.php

Only SIGINT the daemon itself, not its entire process groupClosedPublicActions