Page MenuHomePhabricator
Differential D11837

Allow subscriptions to decline to generate an invoice
ClosedPublic
Actions

Authored by epriestley on Feb 20 2015, 7:42 PM.
Tags
None
Referenced Files
F14372987: D11837.diff
Fri, Dec 20, 8:21 PM
Unknown Object (File)
Sun, Dec 15, 7:44 PM
Unknown Object (File)
Tue, Dec 10, 4:16 PM
Unknown Object (File)
Tue, Dec 10, 9:59 AM
Unknown Object (File)
Tue, Dec 10, 2:15 AM
Unknown Object (File)
Mon, Dec 9, 11:19 AM
Unknown Object (File)
Mon, Dec 9, 12:25 AM
Unknown Object (File)
Mon, Dec 2, 11:30 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPed7823f57716: Allow subscriptions to decline to generate an invoice
Summary

This is a useful capability in Phacility for disabled/suspended instances.

Test Plan

Used bin/phortune invoice to invoice a disabled instance, saw it decline to invoice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28531.Feb 20 2015, 7:42 PM
epriestley retitled this revision from to Allow subscriptions to decline to generate an invoice.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 20 2015, 7:42 PM
btrahan accepted this revision.Feb 20 2015, 10:24 PM
btrahan edited edge metadata.

Looks good though I am assuming theres another diff to fulfill the test plan?

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php
29

Theres some instance implementation that does this logic for the test plan?

This revision is now accepted and ready to land.Feb 20 2015, 10:24 PM
epriestley added a comment.Feb 20 2015, 10:32 PM

The other part was in rSAAS9ab58750 which I just pushed unreviewed because I am a dangerous rogue.

Closed by commit rPed7823f57716: Allow subscriptions to decline to generate an invoice (authored by epriestley, committed by epriestley). · Explain WhyFeb 22 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phortune/
storage/
7 lines
subscription/
7 lines
worker/
8 lines

Diff 28554

View Options

src/applications/phortune/storage/PhortuneSubscription.php

Loading...
View Options

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php

Loading...
View Options

src/applications/phortune/worker/PhortuneSubscriptionWorker.php

Loading...
Phabricator · Built by Phacility