Page MenuHomePhabricator

Allow subscriptions to decline to generate an invoice
ClosedPublic

Authored by epriestley on Feb 20 2015, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:44 PM
Unknown Object (File)
Tue, Dec 10, 4:16 PM
Unknown Object (File)
Tue, Dec 10, 9:59 AM
Unknown Object (File)
Tue, Dec 10, 2:15 AM
Unknown Object (File)
Mon, Dec 9, 11:19 AM
Unknown Object (File)
Mon, Dec 9, 12:25 AM
Unknown Object (File)
Mon, Dec 2, 11:30 PM
Unknown Object (File)
Wed, Nov 27, 8:02 PM
Subscribers

Details

Summary

This is a useful capability in Phacility for disabled/suspended instances.

Test Plan

Used bin/phortune invoice to invoice a disabled instance, saw it decline to invoice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow subscriptions to decline to generate an invoice.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Looks good though I am assuming theres another diff to fulfill the test plan?

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php
29

Theres some instance implementation that does this logic for the test plan?

This revision is now accepted and ready to land.Feb 20 2015, 10:24 PM

The other part was in rSAAS9ab58750 which I just pushed unreviewed because I am a dangerous rogue.

This revision was automatically updated to reflect the committed changes.