Add SUCCESS state and buttons to PHUIErrorView
ClosedPublic
Actions

Authored by chad on Feb 21 2015, 5:17 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP7d4ec48a0ed1: Add SUCCESS state and buttons to PHUIErrorView

Summary

I'm looking at beefing up PHUIErrorView for additional use cases as I remove some older AphrontViews. This will likely morph into PHUIInfoView and be a more lightweight version of PHUIObjectBox.

Test Plan

UIExamples, mobile and desktop layouts. Have actual use cases coming in next diffs (may tweak design more then)

Diff Detail

Repository

rP Phabricator

Branch

error-view-expanded

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4599
Build 4613: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28553.Feb 21 2015, 5:17 PM

chad retitled this revision from to Add SUCCESS state and buttons to PHUIErrorView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 21 2015, 5:17 PM

This may push me to revisit our color palette as well. Will see in actual use.

Inline musing... I'm wondering how SEVERITY_NOTICE ends up getting used now that we have the new SUCCESS severity? Maybe as this new stuff gets deployed it makes sense to turn all / most of the NOTICE into SUCCESS? Time will tell I guess.