Page MenuHomePhabricator
Differential D11837

Allow subscriptions to decline to generate an invoice
ClosedPublic
Actions

Authored by epriestley on Feb 20 2015, 7:42 PM.
Tags
None
Referenced Files
F13980659: D11837.id.diff
Oct 19 2024, 11:51 AM
F13974791: D11837.diff
Oct 18 2024, 7:24 AM
Unknown Object (File)
Oct 11 2024, 6:18 AM
Unknown Object (File)
Oct 11 2024, 6:18 AM
Unknown Object (File)
Oct 11 2024, 6:17 AM
Unknown Object (File)
Oct 11 2024, 6:13 AM
Unknown Object (File)
Sep 24 2024, 12:02 AM
Unknown Object (File)
Sep 1 2024, 8:37 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPed7823f57716: Allow subscriptions to decline to generate an invoice
Summary

This is a useful capability in Phacility for disabled/suspended instances.

Test Plan

Used bin/phortune invoice to invoice a disabled instance, saw it decline to invoice.

Diff Detail

Repository
rP Phabricator
Branch
noinvoice
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4585
Build 4599: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28531.Feb 20 2015, 7:42 PM
epriestley retitled this revision from to Allow subscriptions to decline to generate an invoice.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 20 2015, 7:42 PM
btrahan accepted this revision.Feb 20 2015, 10:24 PM
btrahan edited edge metadata.

Looks good though I am assuming theres another diff to fulfill the test plan?

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php
29

Theres some instance implementation that does this logic for the test plan?

This revision is now accepted and ready to land.Feb 20 2015, 10:24 PM
epriestley added a comment.Feb 20 2015, 10:32 PM

The other part was in rSAAS9ab58750 which I just pushed unreviewed because I am a dangerous rogue.

Closed by commit rPed7823f57716: Allow subscriptions to decline to generate an invoice (authored by epriestley, committed by epriestley). · Explain WhyFeb 22 2015, 1:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phortune/
storage/
7 lines
subscription/
7 lines
worker/
8 lines

Diff 28531

View Options

src/applications/phortune/storage/PhortuneSubscription.php

Loading...
View Options

src/applications/phortune/subscription/PhortuneSubscriptionImplementation.php

Loading...
View Options

src/applications/phortune/worker/PhortuneSubscriptionWorker.php

Loading...
Phabricator · Built by Phacility