Make legalpad document list a little nicer for unsignable documents
ClosedPublic
Actions

Authored by epriestley on Feb 20 2015, 3:24 PM.

Tags

None

Referenced Files

	F18361258: D11834.id28522.diff
	Wed, Aug 27, 11:42 AM

	F18360124: D11834.diff
	Wed, Aug 27, 10:11 AM

	F18251636: D11834.diff
	Thu, Aug 21, 6:26 PM

	F18251601: D11834.diff
	Thu, Aug 21, 6:23 PM

	F18110834: D11834.id28525.diff
	Tue, Aug 12, 12:40 AM

	F18110422: D11834.id28522.diff
	Mon, Aug 11, 7:26 PM

	F18109038: D11834.id.diff
	Mon, Aug 11, 11:25 AM

	F18104152: D11834.diff
	Sun, Aug 10, 10:13 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP543cb1c9004a: Make legalpad document list a little nicer for unsignable documents

Summary

This just cleans things up a little:

Don't show signature status if the document isn't signable.
Show "Not Signable" instead of "No One" to make the meaning more clear in this context, where we don't have a "Who should sign:" sort of cue.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28522.Feb 20 2015, 3:24 PM

epriestley retitled this revision from to Make legalpad document list a little nicer for unsignable documents.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 20 2015, 3:24 PM

chad accepted this revision.Feb 20 2015, 3:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 20 2015, 3:26 PM

Closed by commit rP543cb1c9004a: Make legalpad document list a little nicer for unsignable documents (authored by epriestley, committed by epriestley). · Explain WhyFeb 20 2015, 3:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

query/

LegalpadDocumentSearchEngine.php

65 lines

Diff 28525

View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Make legalpad document list a little nicer for unsignable documentsClosedPublicActions