Make legalpad document list a little nicer for unsignable documents
ClosedPublic
Actions

Authored by epriestley on Feb 20 2015, 3:24 PM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP543cb1c9004a: Make legalpad document list a little nicer for unsignable documents

Summary

This just cleans things up a little:

Don't show signature status if the document isn't signable.
Show "Not Signable" instead of "No One" to make the meaning more clear in this context, where we don't have a "Who should sign:" sort of cue.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

legal1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4581
Build 4595: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28522.Feb 20 2015, 3:24 PM

epriestley retitled this revision from to Make legalpad document list a little nicer for unsignable documents.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 20 2015, 3:24 PM

chad accepted this revision.Feb 20 2015, 3:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 20 2015, 3:26 PM

Closed by commit rP543cb1c9004a: Make legalpad document list a little nicer for unsignable documents (authored by epriestley, committed by epriestley). · Explain WhyFeb 20 2015, 3:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

query/

LegalpadDocumentSearchEngine.php

65 lines

Diff 28522

View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Make legalpad document list a little nicer for unsignable documentsClosedPublicActions