Differential D11830

Search - fix external redirect issue for "help" search
ClosedPublic
Actions

Authored by btrahan on Feb 20 2015, 12:22 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T7335: help from search doesn't work

Commits

Restricted Diffusion Commit
rP84d4142b06b7: Search - fix external redirect issue for "help" search

Summary

Fixes T7335. "help" gets you to a specific diviner doc which is an external link, so make sure the code sets is external for the redirect response in this case.

Test Plan

typed "help" and got some

Diff Detail

Repository

rP Phabricator

Branch

T7335

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4576
Build 4590: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28516.Feb 20 2015, 12:22 AM

btrahan added a task: T7335: help from search doesn't work.

btrahan retitled this revision from to Search - fix external redirect issue for "help" search.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 20 2015, 12:22 AM

epriestley accepted this revision.Feb 20 2015, 12:22 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 20 2015, 12:22 AM

Closed by commit rP84d4142b06b7: Search - fix external redirect issue for "help" search (authored by btrahan, committed by btrahan). · Explain WhyFeb 20 2015, 12:23 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7425: Searching literal "help" 503's without diviner installed (best guess).Mar 2 2015, 5:51 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorJumpNavHandler.php

6 lines

Diff 28516

View Options

src/applications/search/engine/PhabricatorJumpNavHandler.php

Search - fix external redirect issue for "help" searchClosedPublicActions