Page MenuHomePhabricator
Differential D11828

Increase height of logo
ClosedPublic
Actions

Authored by chad on Feb 19 2015, 10:02 PM.
Tags
None
Referenced Files
F13234512: D11828.diff
Tue, May 21, 3:29 AM
F13216608: D11828.id28514.diff
Sat, May 18, 1:32 AM
F13212499: D11828.diff
Fri, May 17, 6:47 AM
F13197408: D11828.diff
Mon, May 13, 12:09 AM
Unknown Object (File)
Fri, May 3, 9:23 AM
Unknown Object (File)
Apr 25 2024, 3:01 AM
Unknown Object (File)
Apr 21 2024, 6:37 PM
Unknown Object (File)
Mar 24 2024, 7:45 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPfb361f206c7b: Increase height of logo
Summary

This increases the transparent space around the Phabricator logo. The logo itself is the same size. This allows for adding of other logos more easily without needing to alter the space provided. (Like Phacility)

Test Plan

Reload page, screenshot logo, pull into Photoshop and verify spacing top and bottom.

pasted_file (664×1 px, 274 KB)

Diff Detail

Repository
rP Phabricator
Branch
bigger-logo-lolz
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4574
Build 4588: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28513.Feb 19 2015, 10:02 PM
chad retitled this revision from to Increase height of logo.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 19 2015, 10:02 PM
chad edited the test plan for this revision. (Show Details)Feb 19 2015, 10:09 PM
epriestley accepted this revision.Feb 19 2015, 10:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2015, 10:41 PM
epriestley added a comment.Feb 19 2015, 10:41 PM

http://www.makemylogobiggercream.com

Closed by commit rPfb361f206c7b: Increase height of logo (authored by chad, committed by chad). · Explain WhyFeb 19 2015, 10:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
sprite/
manifest/
2 lines
menu_1x/
menu_2x/
src/
applications/
celerity/
2 lines
webroot/
rsrc/
css/
application/
base/
4 lines
4 lines
image/

Diff 28513

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/manifest/menu.json

Loading...
View Options

resources/sprite/menu_1x/logo.png

Loading...
View Options

resources/sprite/menu_2x/logo.png

Loading...
View Options

src/applications/celerity/CeleritySpriteGenerator.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
View Options

webroot/rsrc/css/sprite-menu.css

Loading...
View Options

webroot/rsrc/image/sprite-menu-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-menu.png

Loading...
Phabricator · Built by Phacility