Page MenuHomePhabricator
Differential D11814

Remove extra space under PHUIActionPanel
ClosedPublic
Actions

Authored by chad on Feb 18 2015, 11:41 PM.
Tags
None
Referenced Files
F17968278: D11814.id.diff
Fri, Aug 1, 1:16 PM
F17947036: D11814.diff
Thu, Jul 31, 3:36 PM
F17919352: D11814.id28476.diff
Wed, Jul 30, 2:26 AM
F17908594: D11814.diff
Tue, Jul 29, 1:54 PM
Unknown Object (File)
Apr 23 2025, 7:17 PM
Unknown Object (File)
Apr 15 2025, 6:14 PM
Unknown Object (File)
Apr 6 2025, 5:23 AM
Unknown Object (File)
Mar 26 2025, 2:02 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP4e348bb04d79: Remove extra space under PHUIActionPanel
Summary

If we don't have a state in PHUIActionPanelView, don't set the extra padding to display it.

Test Plan

Review in UIExamples.

Diff Detail

Repository
rP Phabricator
Branch
phui-action-panel
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4553
Build 4567: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28475.Feb 18 2015, 11:41 PM
chad retitled this revision from to Remove extra space under PHUIActionPanel.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 18 2015, 11:41 PM
btrahan accepted this revision.Feb 18 2015, 11:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2015, 11:42 PM
Closed by commit rP4e348bb04d79: Remove extra space under PHUIActionPanel (authored by chad, committed by chad). · Explain WhyFeb 18 2015, 11:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
2 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 28475

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility