Page MenuHomePhabricator
Differential D11814

Remove extra space under PHUIActionPanel
ClosedPublic
Actions

Authored by chad on Feb 18 2015, 11:41 PM.
Tags
None
Referenced Files
F14347868: D11814.diff
Thu, Dec 19, 3:48 AM
Unknown Object (File)
Thu, Dec 12, 6:02 AM
Unknown Object (File)
Sat, Dec 7, 1:58 AM
Unknown Object (File)
Sat, Dec 7, 1:57 AM
Unknown Object (File)
Sat, Dec 7, 1:57 AM
Unknown Object (File)
Sat, Dec 7, 1:41 AM
Unknown Object (File)
Fri, Dec 6, 11:14 PM
Unknown Object (File)
Wed, Nov 27, 10:19 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP4e348bb04d79: Remove extra space under PHUIActionPanel
Summary

If we don't have a state in PHUIActionPanelView, don't set the extra padding to display it.

Test Plan

Review in UIExamples.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28475.Feb 18 2015, 11:41 PM
chad retitled this revision from to Remove extra space under PHUIActionPanel.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 18 2015, 11:41 PM
btrahan accepted this revision.Feb 18 2015, 11:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2015, 11:42 PM
Closed by commit rP4e348bb04d79: Remove extra space under PHUIActionPanel (authored by chad, committed by chad). · Explain WhyFeb 18 2015, 11:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
2 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 28476

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility