Improve error messaging for empty Conpherence threads
ClosedPublic
Actions

Authored by epriestley on Feb 16 2015, 6:02 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7275: Show error in Conpherece dialog if no "to" is specified

Commits

Restricted Diffusion Commit
rP9a9c4afe5964: Improve error messaging for empty Conpherence threads

Summary

Fixes T7275. This makes the error stuff a little more consistent with other modern UIs.

Test Plan

Screen_Shot_2015-02-16_at_10.01.04_AM.png (472×621 px, 34 KB)

Diff Detail

Repository

rP Phabricator

Branch

newcon

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4508
Build 4522: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28392.Feb 16 2015, 6:02 PM

epriestley retitled this revision from to Improve error messaging for empty Conpherence threads.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7275: Show error in Conpherece dialog if no "to" is specified.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 16 2015, 6:02 PM

btrahan accepted this revision.Feb 16 2015, 7:19 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 16 2015, 7:19 PM

Closed by commit rP9a9c4afe5964: Improve error messaging for empty Conpherence threads (authored by epriestley, committed by epriestley). · Explain WhyFeb 16 2015, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceNewController.php

11 lines

Diff 28392

View Options

src/applications/conpherence/controller/ConpherenceNewController.php

Improve error messaging for empty Conpherence threadsClosedPublicActions