Paths

Table of Contentst

Differential D11736

Send emails for email invites
ClosedPublic
Actions

Authored by epriestley on Feb 10 2015, 9:19 PM.

Tags

None

Referenced Files

	F13269669: D11736.diff
	Wed, May 29, 6:43 AM

	F13256739: D11736.diff
	Sat, May 25, 4:41 PM

	F13241441: D11736.id28276.diff
	Wed, May 22, 9:02 PM

	F13230016: D11736.id28276.diff
	Mon, May 20, 8:09 PM

	F13221000: D11736.id28301.diff
	Sun, May 19, 2:11 AM

	Unknown Object (File)
	Tue, May 7, 9:22 AM

	Unknown Object (File)
	May 2 2024, 3:01 PM

	Unknown Object (File)
	Apr 30 2024, 2:45 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue
T7152: Improve inviting new users to a Phacility instance

Commits

Restricted Diffusion Commit
rP6f90fbdef806: Send emails for email invites

Summary

Ref T7152. Ref T3554.

When an administrator clicks "send invites", queue tasks to send the invites.
Then, actually send the invites.
Make the links in the invites work properly.
Also provide bin/worker execute to make debugging one-off workers like this easier.
Clean up some UI, too.

Test Plan

We now get as far as the exception which is a placeholder for a registration workflow.

Screen_Shot_2015-02-10_at_1.15.39_PM.png (1×1 px, 181 KB)

Screen_Shot_2015-02-10_at_1.16.07_PM.png (780×1 px, 203 KB)

Screen_Shot_2015-02-10_at_1.15.55_PM.png (1×1 px, 142 KB)

Diff Detail

Repository

Branch

invite3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/people/controller/PhabricatorPeopleInviteSendController.php:75	XHP16	TODO Comment
Advice	src/applications/people/controller/PhabricatorPeopleInviteSendController.php:106	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 4439
Build 4453: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28276.Feb 10 2015, 9:19 PM

epriestley retitled this revision from to Send emails for email invites.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7152: Improve inviting new users to a Phacility instance, T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 10 2015, 9:19 PM

btrahan accepted this revision.Feb 10 2015, 9:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2015, 9:38 PM

Closed by commit rP6f90fbdef806: Send emails for email invites (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2015, 2:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

auth/

data/

PhabricatorAuthInviteAction.php

18 lines

engine/

PhabricatorAuthInviteEngine.php

7 lines

query/

PhabricatorAuthInviteQuery.php

1 line

PhabricatorAuthInviteSearchEngine.php

16 lines

storage/

PhabricatorAuthInvite.php

10 lines

worker/

PhabricatorAuthInviteWorker.php

60 lines

people/

controller/

PhabricatorPeopleInviteSendController.php

43 lines

infrastructure/

daemon/

workers/

management/

PhabricatorWorkerManagementExecuteWorkflow.php

61 lines

Diff 28276

src/__phutil_library_map__.php

Loading...

src/applications/auth/data/PhabricatorAuthInviteAction.php

Loading...

src/applications/auth/engine/PhabricatorAuthInviteEngine.php

Loading...

src/applications/auth/query/PhabricatorAuthInviteQuery.php

Loading...

src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php

Loading...

src/applications/auth/storage/PhabricatorAuthInvite.php

Loading...

src/applications/auth/worker/PhabricatorAuthInviteWorker.php

Loading...

src/applications/people/controller/PhabricatorPeopleInviteSendController.php

Loading...

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php

Loading...