Paths

Table of Contentst

Differential D11730

Rename a constant
ClosedPublic
Actions

Authored by joshuaspence on Feb 10 2015, 7:40 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPd66cbff29811: Rename a constant

Summary

Rename DifferentialChangesetParser::WHITESPACE_IGNORE_FORCE to DifferentialChangesetParser::WHITESPACE_IGNORE_ALL to better reflect reality.

Test Plan

Viewed a diff with various settings for the "Whitespace changes" option.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4420
Build 4434: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28246.Feb 10 2015, 7:40 AM

joshuaspence retitled this revision from to Rename a constant.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 10 2015, 7:40 AM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence edited the test plan for this revision. (Show Details)Feb 10 2015, 12:29 PM

joshuaspence edited edge metadata.

epriestley accepted this revision.Feb 10 2015, 2:20 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Feb 10 2015, 2:20 PM

Closed by commit rPd66cbff29811: Rename a constant (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 10 2015, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

8 lines

view/

DifferentialRevisionUpdateHistoryView.php

8 lines

Diff 28246

View Options

src/applications/differential/parser/DifferentialChangesetParser.php