Page MenuHomePhabricator

losen pep8 version check
ClosedPublic

Authored by cburroughs on Feb 10 2015, 3:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 3:48 AM
Unknown Object (File)
Tue, Nov 26, 1:14 AM
Unknown Object (File)
Tue, Nov 26, 1:09 AM
Unknown Object (File)
Mon, Nov 25, 6:55 PM
Unknown Object (File)
Mon, Nov 25, 12:37 AM
Unknown Object (File)
Nov 22 2024, 11:41 AM
Unknown Object (File)
Nov 21 2024, 1:34 PM
Unknown Object (File)
Nov 20 2024, 1:32 PM

Details

Summary

pep8 has used both 2 (1.2) and 3 (1.2.1) digit versions. Losen
the version check to allow for both.

NOTE: This is the same regex as flake8.
Test Plan

arc unit with a 2 and 3 digit pep8 version on $PATH.

Diff Detail

Repository
rARC Arcanist
Branch
pep8-version
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 4418
Build 4432: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
122 msArcanistRubyLinterTestCase::testLinter
60 msArcanistChmodLinterTestCase::testLinter
0 msArcanistClosureLinterTestCase::testVersion
51 msArcanistCommitLinterTestCase::testLinter
0 msArcanistCpplintLinterTestCase::testVersion
View Full Test Results (1 Failed · 22 Passed · 28 Skipped)

Event Timeline

cburroughs retitled this revision from to losen pep8 version check.
cburroughs updated this object.
cburroughs edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 10 2015, 2:17 PM
This revision was automatically updated to reflect the committed changes.