Page MenuHomePhabricator

Remove side spacing on code remarkup
ClosedPublic

Authored by chad on Feb 9 2015, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 3:58 PM
Unknown Object (File)
Aug 30 2024, 5:02 PM
Unknown Object (File)
Aug 29 2024, 7:02 AM
Unknown Object (File)
Aug 28 2024, 11:17 AM
Unknown Object (File)
Aug 23 2024, 9:05 AM
Unknown Object (File)
Aug 18 2024, 11:45 PM
Unknown Object (File)
Aug 18 2024, 10:50 PM
Unknown Object (File)
Aug 17 2024, 5:33 PM

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPb4d03bb26c61: Remove side spacing on code remarkup
Summary

Sets everything up flush, I think this is the only indented block left.

Test Plan

Write some code.

Screen_Shot_2015-02-09_at_10.30.59_AM.png (222×960 px, 46 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup-code
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4401
Build 4414: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Remove side spacing on code remarkup.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a subscriber: Design.
epriestley edited edge metadata.

Not really related, but maybe we should lighten the background colors on these blocks? Their brightness/saturation feels a little out of place to me with the rest of the more nuanced modern design, especially in Diviner/Phriction.

This revision is now accepted and ready to land.Feb 12 2015, 6:08 PM

Yeah, it's something I've noticed as well.

This revision was automatically updated to reflect the committed changes.