Page MenuHomePhabricator
Differential D11721

Remove side spacing on code remarkup
ClosedPublic
Actions

Authored by chad on Feb 9 2015, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 6:02 PM
Unknown Object (File)
Sat, Feb 8, 3:02 AM
Unknown Object (File)
Sat, Feb 8, 3:02 AM
Unknown Object (File)
Sat, Feb 8, 3:02 AM
Unknown Object (File)
Sat, Feb 8, 3:02 AM
Unknown Object (File)
Sat, Feb 8, 2:57 AM
Unknown Object (File)
Sat, Feb 8, 2:30 AM
Unknown Object (File)
Sat, Feb 8, 2:30 AM
View All Files
Subscribers
epriestley
Korvin
Design

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPb4d03bb26c61: Remove side spacing on code remarkup
Summary

Sets everything up flush, I think this is the only indented block left.

Test Plan

Write some code.

Screen_Shot_2015-02-09_at_10.30.59_AM.png (222×960 px, 46 KB)

Diff Detail

Repository
rP Phabricator
Branch
remarkup-code
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4400
Build 4413: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28209.Feb 9 2015, 6:32 PM
chad retitled this revision from to Remove side spacing on code remarkup.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a subscriber: Design.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 9 2015, 6:32 PM
chad edited the test plan for this revision. (Show Details)Feb 9 2015, 6:32 PM
chad updated this revision to Diff 28210.Feb 9 2015, 6:42 PM
  • test
chad mentioned this in T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.Feb 9 2015, 6:45 PM
epriestley accepted this revision.Feb 12 2015, 6:08 PM
epriestley edited edge metadata.

Not really related, but maybe we should lighten the background colors on these blocks? Their brightness/saturation feels a little out of place to me with the rest of the more nuanced modern design, especially in Diviner/Phriction.

This revision is now accepted and ready to land.Feb 12 2015, 6:08 PM
chad added a comment.Feb 12 2015, 6:20 PM

Yeah, it's something I've noticed as well.

Closed by commit rPb4d03bb26c61: Remove side spacing on code remarkup (authored by chad, committed by chad). · Explain WhyFeb 18 2015, 5:08 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Feb 18 2015, 5:10 PM

pasted_file (435×742 px, 72 KB)

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
2 lines

Diff 28209

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility