Page MenuHomePhabricator
Differential D11711

Try out PHUIActionPanelView in Almanac
AbandonedPublic
Actions

Authored by chad on Feb 8 2015, 4:52 AM.
Tags
None
Referenced Files
F13221860: D11711.diff
Sun, May 19, 3:06 AM
F13218232: D11711.diff
Sat, May 18, 11:10 AM
F13204401: D11711.diff
Wed, May 15, 12:33 AM
F13187338: D11711.diff
Sat, May 11, 4:28 AM
Unknown Object (File)
Tue, May 7, 7:35 AM
Unknown Object (File)
Fri, May 3, 6:56 AM
Unknown Object (File)
Thu, Apr 25, 1:21 AM
Unknown Object (File)
Apr 11 2024, 8:52 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Summary

Converts the Almanac Console to PHUIActionPanelView for testing.

Test Plan

Seems reasonable, but might be too big in practice.

pasted_file (455×917 px, 69 KB)

Diff Detail

Repository
rP Phabricator
Branch
almanac-home
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4381
Build 4394: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28183.Feb 8 2015, 4:52 AM
chad retitled this revision from to Try out PHUIActionPanelView in Almanac.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 8 2015, 4:52 AM
chad edited the test plan for this revision. (Show Details)Feb 8 2015, 4:53 AM
epriestley edited edge metadata.Feb 9 2015, 2:12 PM

Does this look junky with 3 panels (i.e., no doc panel)?

chad added a comment.Feb 9 2015, 4:41 PM

Haha, probably, not a big deal. Basically not much gained here unless you want some underlying status bubbled up, like offline hosts.

chad planned changes to this revision.Feb 19 2015, 4:13 PM
chad updated this revision to Diff 28567.Feb 22 2015, 10:32 PM
chad edited edge metadata.
  • Remove documentation panel
epriestley mentioned this in D11860: Support autoscaling daemons in phd.Feb 23 2015, 12:08 AM
epriestley mentioned this in rP48fc3126a124: Support autoscaling daemons in phd.Feb 24 2015, 10:53 PM
btrahan accepted this revision.Mar 23 2015, 5:37 PM
btrahan edited edge metadata.

Not sure if this is still valid or not, but in the assumption its just stalled 'cuz Evan or I was supposed to accept....

ACCEPTED!

This revision is now accepted and ready to land.Mar 23 2015, 5:37 PM
chad added a comment.Mar 23 2015, 5:39 PM

This mostly felt like a side-grade. I have a rough mock to update the ActionPanels sitting on my desktop, but it hasn't been built.

epriestley added a comment.Mar 23 2015, 5:42 PM

Yeah, this doesn't feel bad but doesn't feel like a clear step forward either.

chad planned changes to this revision.Mar 24 2015, 8:00 PM
chad abandoned this revision.Apr 2 2015, 3:58 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
almanac/
controller/
68 lines
view/
phui/
1 line
webroot/
rsrc/
css/
phui/
3 lines

Diff 28183

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility