mysqldump output can end up having weird encoding issues when raw BLOBs are in the output, preventing the backup restoration from succeeding. This hex-encodes blobs in the dump from the backup workflow causing the output file to only contain ASCII and ensure imports are successful.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP28b23fd789dc: Use --hex-blob flag in bin/storage dump
Had issues restoring a backup from the original mysqldump command issued by this workflow. Ran the same command with this flag added and I was able to restore the backup.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hexdump
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 4371 Build 4384: [Placeholder Plan] Wait for 30 Seconds
Time | Test | |
---|---|---|
0 ms | AphrontIsolatedDatabaseConnectionTestCase::testTransactionRollback | |
0 ms | AphrontMySQLDatabaseConnectionTestCase::testConnectionFailures | |
0 ms | AphrontIsolatedDatabaseConnectionTestCase::testDeletePermitted | |
0 ms | AphrontIsolatedDatabaseConnectionTestCase::testInsertGeneratesID | |
0 ms | AphrontIsolatedDatabaseConnectionTestCase::testIsolation | |
View Full Test Results (2 Failed · 5 Passed) |
Event Timeline
Comment Actions
Cool. We compress these anyway (and advise compression) and it looks like this has been around since at least MySQL 5.0, so this should strictly produce less-error-prone dumps.