Page MenuHomePhabricator

Correct private key permissions before extracting public key in bin/almanac register
ClosedPublic

Authored by epriestley on Feb 5 2015, 10:05 PM.
Tags
None
Referenced Files
F15523381: D11700.diff
Mon, Apr 21, 1:03 AM
F15471916: D11700.id28154.diff
Sat, Apr 5, 9:34 AM
F15470498: D11700.id28156.diff
Fri, Apr 4, 11:00 PM
F15460074: D11700.id28156.diff
Mon, Mar 31, 7:57 PM
F15318480: D11700.diff
Mar 6 2025, 8:27 PM
Unknown Object (File)
Jan 25 2025, 1:08 PM
Unknown Object (File)
Jan 21 2025, 10:37 AM
Unknown Object (File)
Jan 21 2025, 8:46 AM
Subscribers

Details

Summary

ssh-keygen declines to run on a too-public key. Write the correctly-restricted key a little earlier in the workflow.

Test Plan
epriestley@orbital ~/dev/phabricator $ chmod 644 ~/dev/core/conf/keys/daemon.key 
epriestley@orbital ~/dev/phabricator $ ./bin/almanac register --private-key ~/dev/core/conf/keys/daemon.key --identify-as local.phacility.net --device daemon.phacility.net --force --allow-key-reuse
Installing public key...
Installing private key...
Installing device ID...
 HOST REGISTERED  This host has been registered as "local.phacility.net" and a trusted keypair has been installed.
epriestley@orbital ~/dev/phabricator $

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Correct private key permissions before extracting public key in bin/almanac register.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2015, 10:07 PM
This revision was automatically updated to reflect the committed changes.