Paths

Table of Contentst

Differential D11700

Correct private key permissions before extracting public key in bin/almanac register
ClosedPublic
Actions

Authored by epriestley on Feb 5 2015, 10:05 PM.

Tags

None

Referenced Files

	F13243235: D11700.diff
	Thu, May 23, 3:35 AM

	F13219852: D11700.diff
	Sat, May 18, 9:26 PM

	F13207839: D11700.id.diff
	Thu, May 16, 4:46 AM

	F13194206: D11700.diff
	Sun, May 12, 9:24 PM

	F13179397: D11700.diff
	Wed, May 8, 9:10 PM

	Unknown Object (File)
	Sat, May 4, 6:39 PM

	Unknown Object (File)
	Thu, May 2, 7:15 AM

	Unknown Object (File)
	Tue, Apr 30, 11:19 PM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP57f1ab705e28: Correct private key permissions before extracting public key in bin/almanac…

Summary

ssh-keygen declines to run on a too-public key. Write the correctly-restricted key a little earlier in the workflow.

Test Plan

epriestley@orbital ~/dev/phabricator $ chmod 644 ~/dev/core/conf/keys/daemon.key 
epriestley@orbital ~/dev/phabricator $ ./bin/almanac register --private-key ~/dev/core/conf/keys/daemon.key --identify-as local.phacility.net --device daemon.phacility.net --force --allow-key-reuse
Installing public key...
Installing private key...
Installing device ID...
 HOST REGISTERED  This host has been registered as "local.phacility.net" and a trusted keypair has been installed.
epriestley@orbital ~/dev/phabricator $

Diff Detail

Repository

Branch

regperms

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4364
Build 4377: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28154.Feb 5 2015, 10:05 PM

epriestley retitled this revision from to Correct private key permissions before extracting public key in bin/almanac register.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 5 2015, 10:05 PM

btrahan accepted this revision.Feb 5 2015, 10:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Feb 5 2015, 10:07 PM

Closed by commit rP57f1ab705e28: Correct private key permissions before extracting public key in bin/almanac… (authored by epriestley, committed by epriestley). · Explain WhyFeb 5 2015, 10:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

management/

AlmanacManagementRegisterWorkflow.php

16 lines

Diff 28154

src/applications/almanac/management/AlmanacManagementRegisterWorkflow.php

Loading...