Page MenuHomePhabricator
Differential D11662

Remove the `ArcanistArcanistLinterTestCase`
ClosedPublic
Actions

Authored by joshuaspence on Feb 3 2015, 9:20 PM.
Tags
None
Referenced Files
F15436736: D11662.diff
Tue, Mar 25, 4:17 PM
F15426061: D11662.id28069.diff
Sun, Mar 23, 6:56 AM
F15418380: D11662.id28069.diff
Thu, Mar 20, 10:57 PM
F15413275: D11662.id28069.diff
Wed, Mar 19, 5:43 PM
F15369927: D11662.diff
Wed, Mar 12, 8:43 AM
F15335130: D11662.id28100.diff
Sat, Mar 8, 2:24 PM
Unknown Object (File)
Feb 18 2025, 7:13 AM
Unknown Object (File)
Feb 16 2025, 10:21 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC992d939e3a5c: Remove the `ArcanistArcanistLinterTestCase`
Summary

I don't think that this provides too much value. I think that we should rework this to be inferred from the .arcconfig file perhaps?

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28069.Feb 3 2015, 9:20 PM
joshuaspence retitled this revision from to Remove the `ArcanistArcanistLinterTestCase`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 9:20 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 3 2015, 9:40 PM
epriestley edited edge metadata.

Yeah, these hardcodes feel really awkward. We can find some better place for this eventually.

This revision is now accepted and ready to land.Feb 3 2015, 9:40 PM
Closed by commit rARC992d939e3a5c: Remove the `ArcanistArcanistLinterTestCase` (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 4 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28100

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistChmodLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistCommitLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistFilenameLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistGeneratedLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJSONLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistMergeConflictLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistNoLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistSpellingLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistTextLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistXMLLinterTestCase.php

Loading...
Phabricator · Built by Phacility