Page MenuHomePhabricator

Policy - convert repository worker to query revision with policy query
ClosedPublic

Authored by btrahan on Feb 3 2015, 8:02 PM.
Tags
None
Referenced Files
F13298906: D11654.diff
Fri, Jun 7, 7:24 AM
F13283168: D11654.diff
Sun, Jun 2, 12:55 PM
F13268244: D11654.diff
Wed, May 29, 4:49 AM
F13256957: D11654.id28055.diff
Sat, May 25, 7:14 PM
F13252023: D11654.diff
Sat, May 25, 1:00 AM
F13247765: D11654.diff
Thu, May 23, 10:20 PM
F13225442: D11654.diff
Sun, May 19, 3:10 PM
F13203968: D11654.diff
Wed, May 15, 12:15 AM
Subscribers

Details

Summary

Ref T7094. I guess theoretically someone could be making a commit and have just lost access to the revision and thus this could link this commit to that revision, but this all seems far fetched an weird? We also don't necessarily have the commit author's true identity since commit parsing can be a little funky to begin with. Anyhoo, functionally, this makes things no worse, but I am removing the TODO that would make us look at this in a fun way.

Test Plan

bin/repository reparse --owners rXvalidhash and it worked

Diff Detail

Repository
rP Phabricator
Branch
T7094_13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4292
Build 4305: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Policy - convert repository worker to query revision with policy query.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.