Differential D11652

Policy - move some owners code into an editor class and check policy better
ClosedPublic
Actions

Authored by btrahan on Feb 3 2015, 7:37 PM.

Tags

None

Referenced Files

	F15437839: D11652.id28039.diff
	Tue, Mar 25, 9:45 PM

	F15365517: D11652.diff
	Tue, Mar 11, 1:57 PM

	Unknown Object (File)
	Mar 3 2025, 4:09 PM

	Unknown Object (File)
	Feb 20 2025, 4:00 AM

	Unknown Object (File)
	Feb 8 2025, 1:44 PM

	Unknown Object (File)
	Feb 8 2025, 2:19 AM

	Unknown Object (File)
	Feb 8 2025, 2:19 AM

	Unknown Object (File)
	Feb 8 2025, 2:19 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7094: Clean up T603

Commits

Restricted Diffusion Commit
rP9b65370398cc: Policy - move some owners code into an editor class and check policy better

Summary

Ref T7094. We basically need to make sure folks can see repositories before making owners packages about code within. This cleans up things a little bit by moving a bunch of logic out of the storage class and into an editor class.

Test Plan

made a package and it worked! deleted a package and it worked! discovered buggy behavior in more complicated edits and filed T7127; note this bug exists before and after this diff.

Diff Detail

Repository

Branch

T7094_11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4287
Build 4300: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28039.Feb 3 2015, 7:37 PM

btrahan added a task: T7094: Clean up T603.

btrahan retitled this revision from to Policy - move some owners code into an editor class and check policy better.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 3 2015, 7:37 PM

btrahan mentioned this in T7127: Saving new path list when deletes occur is erroneous at best.Feb 3 2015, 7:38 PM

epriestley accepted this revision.Feb 3 2015, 7:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 7:39 PM

Closed by commit rP9b65370398cc: Policy - move some owners code into an editor class and check policy better (authored by btrahan, committed by btrahan). · Explain WhyFeb 3 2015, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

owners/

controller/

PhabricatorOwnersDeleteController.php

6 lines

PhabricatorOwnersEditController.php

6 lines

editor/

PhabricatorOwnersPackageEditor.php

198 lines

storage/

PhabricatorOwnersPackage.php

189 lines

Diff 28039

src/__phutil_library_map__.php

Loading...

src/applications/owners/controller/PhabricatorOwnersDeleteController.php

Loading...

src/applications/owners/controller/PhabricatorOwnersEditController.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageEditor.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...