Page MenuHomePhabricator

Policy - move some owners code into an editor class and check policy better
ClosedPublic

Authored by btrahan on Feb 3 2015, 7:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 4:00 AM
Unknown Object (File)
Sat, Feb 8, 1:44 PM
Unknown Object (File)
Sat, Feb 8, 2:19 AM
Unknown Object (File)
Sat, Feb 8, 2:19 AM
Unknown Object (File)
Sat, Feb 8, 2:19 AM
Unknown Object (File)
Sat, Feb 8, 2:19 AM
Unknown Object (File)
Wed, Feb 5, 4:03 AM
Unknown Object (File)
Wed, Feb 5, 4:03 AM
Subscribers

Details

Summary

Ref T7094. We basically need to make sure folks can see repositories before making owners packages about code within. This cleans up things a little bit by moving a bunch of logic out of the storage class and into an editor class.

Test Plan

made a package and it worked! deleted a package and it worked! discovered buggy behavior in more complicated edits and filed T7127; note this bug exists before and after this diff.

Diff Detail

Repository
rP Phabricator
Branch
T7094_11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4287
Build 4300: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Policy - move some owners code into an editor class and check policy better.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:39 PM
This revision was automatically updated to reflect the committed changes.