Page MenuHomePhabricator
Differential D11611

Use XHPAST version instead of checksum as cache version
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 10:08 AM.
Tags
None
Referenced Files
F15525486: D11611.diff
Mon, Apr 21, 2:45 PM
F15502261: D11611.diff
Sun, Apr 13, 11:22 PM
F15466410: D11611.id27971.diff
Thu, Apr 3, 5:09 AM
F15458718: D11611.id27946.diff
Mon, Mar 31, 6:34 AM
F15442120: D11611.id27971.diff
Wed, Mar 26, 9:36 PM
F15419425: D11611.id27971.diff
Mar 21 2025, 6:00 AM
F15393518: D11611.id27971.diff
Mar 15 2025, 9:10 PM
F15391372: D11611.id27971.diff
Mar 15 2025, 9:33 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC0ef326f3a5a5: Use XHPAST version instead of checksum as cache version
Summary

Rely on the output of xhpast --version when determing the lint cache key.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4231
Build 4244: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27946.Feb 2 2015, 10:08 AM
joshuaspence retitled this revision from to Use XHPAST version instead of checksum as cache version.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 10:08 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 2 2015, 1:59 PM
epriestley edited edge metadata.

This is sort of bad if you're developing XHPAST and testing the linter, but I think it's reasonable to expect developers in that position to pass flags to disable the cache if it's otherwise enabled.

This revision is now accepted and ready to land.Feb 2 2015, 1:59 PM
epriestley added a comment.Feb 2 2015, 1:59 PM

(That is, you may make a number of builds which all have the same version number but different behavior.)

joshuaspence added a comment.Feb 2 2015, 7:56 PM

Yeah, I think it's reasonable to expect to have to disable the lint cache in that scenario. If we really wanted to, we could append the version number with a timestamp for "dev" purposes.

Closed by commit rARC0ef326f3a5a5: Use XHPAST version instead of checksum as cache version (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 7:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
6 lines

Diff 27946

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...
Phabricator · Built by Phacility