Differential D11608

Change PHUIPagedFormView to extend AphrontView
ClosedPublic
Actions

Authored by chad on Feb 2 2015, 3:58 AM.

Tags

None

Referenced Files

	F14379837: D11608.diff
	Sat, Dec 21, 3:17 AM

	Unknown Object (File)
	Wed, Dec 11, 2:08 AM

	Unknown Object (File)
	Wed, Nov 27, 11:07 AM

	Unknown Object (File)
	Sat, Nov 23, 9:42 AM

	Unknown Object (File)
	Sat, Nov 23, 5:27 AM

	Unknown Object (File)
	Nov 18 2024, 8:31 PM

	Unknown Object (File)
	Nov 15 2024, 11:13 AM

	Unknown Object (File)
	Nov 11 2024, 8:25 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP582e13fc38b3: Change PHUIPagedFormView to extend AphrontView

Summary

Debugging crumbs in repository editing, and it seems there are stray divs that aren't used from extending AphrontTagView. I don't see any specific reason this needs to be from AphrontTagView, so changing it. Of course I'm not sure this is correct, so feel free to reject if I'm missing some obvious or non-obvious reasons.

Test Plan

Review editing a repositor, don't see extra div.

Diff Detail

Repository

Branch

phui-paged-form

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4224
Build 4237: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27932.Feb 2 2015, 3:58 AM

chad retitled this revision from to Change PHUIPagedFormView to extend AphrontView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 2 2015, 3:58 AM

epriestley accepted this revision.Feb 2 2015, 4:01 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 2 2015, 4:01 AM

Closed by commit rP582e13fc38b3: Change PHUIPagedFormView to extend AphrontView (authored by chad, committed by chad). · Explain WhyFeb 2 2015, 4:10 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

PHUIPagedFormView.php

4 lines

Diff 27932

src/view/form/PHUIPagedFormView.php

Loading...