Page MenuHomePhabricator

Change PHUIPagedFormView to extend AphrontView
ClosedPublic

Authored by chad on Feb 2 2015, 3:58 AM.
Tags
None
Referenced Files
F13388795: D11608.diff
Mon, Jul 1, 2:17 PM
F13377931: D11608.diff
Sat, Jun 29, 4:22 AM
F13363530: D11608.diff
Wed, Jun 26, 3:47 AM
F13363119: D11608.id27932.diff
Wed, Jun 26, 2:18 AM
F13351331: D11608.diff
Sun, Jun 23, 8:40 AM
F13337374: D11608.diff
Wed, Jun 19, 9:30 AM
F13325968: D11608.diff
Sat, Jun 15, 2:26 AM
F13293577: D11608.diff
Wed, Jun 5, 9:39 AM
Subscribers

Details

Summary

Debugging crumbs in repository editing, and it seems there are stray divs that aren't used from extending AphrontTagView. I don't see any specific reason this needs to be from AphrontTagView, so changing it. Of course I'm not sure this is correct, so feel free to reject if I'm missing some obvious or non-obvious reasons.

Test Plan

Review editing a repositor, don't see extra div.

Diff Detail

Repository
rP Phabricator
Branch
phui-paged-form
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4224
Build 4237: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Change PHUIPagedFormView to extend AphrontView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2015, 4:01 AM
This revision was automatically updated to reflect the committed changes.