Paths

Table of Contentst

Differential D11588

Allow `DivinerPublisher` to be specified as a flag
ClosedPublic
Actions

Authored by joshuaspence on Jan 30 2015, 11:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPd4b78af10271: Allow `DivinerPublisher` to be specified as a flag

Summary

Allow the DivinerPublisher subclass to be specified via ./bin/divner generate --publisher .... In particular, this allows use of the (mostly broken) DivinerStaticPublisher.

Test Plan

Ran ./bin/diviner generate --publisher DivinerStaticPublisher

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4213
Build 4226: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27882.Jan 30 2015, 11:13 PM

joshuaspence retitled this revision from to Allow `DivinerPublisher` to be specified as a flag.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 30 2015, 11:13 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 31 2015, 2:25 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 31 2015, 2:25 PM

Chain method calls

joshuaspence updated this object.Feb 1 2015, 11:05 AM

Closed by commit rPd4b78af10271: Allow `DivinerPublisher` to be specified as a flag (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 1 2015, 11:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

publisher/

DivinerPublisher.php

1 line

workflow/

DivinerGenerateWorkflow.php

37 lines

Diff 27906

View Options

src/applications/diviner/publisher/DivinerPublisher.php