Page MenuHomePhabricator
Differential D11598

Minor tidying of `DivinerPublisher` classes
ClosedPublic
Actions

Authored by joshuaspence on Jan 31 2015, 10:10 PM.
Tags
None
Referenced Files
F18187439: D11598.id27893.diff
Sat, Aug 16, 7:46 PM
F18050619: D11598.id27915.diff
Sun, Aug 3, 8:32 PM
F17960133: D11598.id.diff
Fri, Aug 1, 8:50 AM
F17945612: D11598.diff
Thu, Jul 31, 12:46 PM
F17830680: D11598.id27893.diff
Sat, Jul 26, 11:17 AM
F17731784: D11598.id27893.diff
Jul 20 2025, 2:45 AM
F17731768: D11598.id27915.diff
Jul 20 2025, 2:42 AM
F17731053: D11598.diff
Jul 20 2025, 12:05 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP0fc2464e0373: Minor tidying of `DivinerPublisher` classes
Summary

Self-explanatory. Also made a few methods final.

Test Plan

Eyeball it.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4207
Build 4220: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27893.Jan 31 2015, 10:10 PM
joshuaspence retitled this revision from to Minor tidying of `DivinerPublisher` classes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 31 2015, 10:10 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 31 2015, 10:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2015, 10:29 PM
Closed by commit rP0fc2464e0373: Minor tidying of `DivinerPublisher` classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 1 2015, 8:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
publisher/
8 lines
37 lines
3 lines

Diff 27893

View Options

src/applications/diviner/publisher/DivinerLivePublisher.php

Loading...
View Options

src/applications/diviner/publisher/DivinerPublisher.php

Loading...
View Options

src/applications/diviner/publisher/DivinerStaticPublisher.php

Loading...
Phabricator · Built by Phacility