Minor tidying of `DivinerAtom` and `DivinerAtomRef`
ClosedPublic
Actions

Authored by joshuaspence on Jan 30 2015, 11:50 PM.

Tags

None

Referenced Files

	F14039451: D11592.diff
	Mon, Nov 11, 5:41 AM

	F14023588: D11592.diff
	Thu, Nov 7, 3:00 AM

	F14015817: D11592.diff
	Mon, Nov 4, 1:15 AM

	F14011276: D11592.diff
	Thu, Oct 31, 10:28 PM

	F14008085: D11592.id27886.diff
	Tue, Oct 29, 3:19 PM

	F14000847: D11592.id27886.diff
	Fri, Oct 25, 1:43 AM

	F13997343: D11592.diff
	Thu, Oct 24, 3:50 AM

	F13984161: D11592.id27916.diff
	Sun, Oct 20, 11:23 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP87deb72cdb77: Minor tidying of `DivinerAtom` and `DivinerAtomRef`

Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4200
Build 4213: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27886.Jan 30 2015, 11:50 PM

joshuaspence retitled this revision from to Minor tidying of `DivinerAtom` and `DivinerAtomRef`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 30 2015, 11:50 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 31 2015, 2:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 31 2015, 2:28 PM

Closed by commit rP87deb72cdb77: Minor tidying of `DivinerAtom` and `DivinerAtomRef` (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 1 2015, 8:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

atom/

DivinerAtom.php

50 lines

DivinerAtomRef.php

60 lines

Diff 27886

View Options

src/applications/diviner/atom/DivinerAtom.php