Page MenuHomePhabricator
Differential D11588

Allow `DivinerPublisher` to be specified as a flag
ClosedPublic
Actions

Authored by joshuaspence on Jan 30 2015, 11:13 PM.
Tags
None
Referenced Files
F14018264: D11588.id27906.diff
Tue, Nov 5, 7:15 AM
F14012104: D11588.id27882.diff
Fri, Nov 1, 7:18 AM
F13982320: D11588.id27908.diff
Sat, Oct 19, 10:22 PM
F13973520: D11588.id27882.diff
Fri, Oct 18, 1:14 AM
F13968954: D11588.id27908.diff
Wed, Oct 16, 11:40 PM
Unknown Object (File)
Sun, Oct 13, 12:42 PM
Unknown Object (File)
Fri, Oct 11, 9:18 PM
Unknown Object (File)
Oct 7 2024, 7:05 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPd4b78af10271: Allow `DivinerPublisher` to be specified as a flag
Summary

Allow the DivinerPublisher subclass to be specified via ./bin/divner generate --publisher .... In particular, this allows use of the (mostly broken) DivinerStaticPublisher.

Test Plan

Ran ./bin/diviner generate --publisher DivinerStaticPublisher

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4196
Build 4209: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27882.Jan 30 2015, 11:13 PM
joshuaspence retitled this revision from to Allow `DivinerPublisher` to be specified as a flag.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 30 2015, 11:13 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 31 2015, 2:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2015, 2:25 PM
joshuaspence updated this revision to Diff 27906.Feb 1 2015, 11:04 AM
joshuaspence edited edge metadata.

Chain method calls

joshuaspence updated this object.Feb 1 2015, 11:05 AM
Closed by commit rPd4b78af10271: Allow `DivinerPublisher` to be specified as a flag (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 1 2015, 11:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
workflow/
26 lines

Diff 27882

View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
Phabricator · Built by Phacility