Page MenuHomePhabricator

Application Emails - add datasource so we can have a typeahead
ClosedPublic

Authored by btrahan on Jan 28 2015, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 8:24 AM
Unknown Object (File)
Fri, Feb 21, 10:26 AM
Unknown Object (File)
Fri, Feb 21, 10:25 AM
Unknown Object (File)
Fri, Feb 21, 10:17 AM
Unknown Object (File)
Fri, Feb 21, 10:17 AM
Unknown Object (File)
Fri, Feb 21, 10:16 AM
Unknown Object (File)
Fri, Feb 21, 9:52 AM
Unknown Object (File)
Fri, Feb 21, 9:51 AM
Subscribers

Details

Summary

Ref T5039. This will be necessary for Herald integration so users can make rules like "if app email is one of x, y, or z add projects foo, bar, and metallica." I think its best to do an actual typeahead here -- users select full email addresses -- rather than support prefix, suffix, etc stuff on the email address. I think the latter approach would yield lots of confusion, as well as prevent us from (more) easily providing diagnostic tools about what happened when and why.

Test Plan

hacked a maniphest tokenizer to use this new datasource and it worked

Diff Detail

Repository
rP Phabricator
Branch
T5039
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4139
Build 4152: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Application Emails - add datasource so we can have a typeahead.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Ah, yeah, this is probably a better approach.

One maybe-weird thing is that editing an email will affect rules, but that's probably reasonable/expected.

This revision is now accepted and ready to land.Jan 28 2015, 10:14 PM
This revision was automatically updated to reflect the committed changes.