Page MenuHomePhabricator
Differential D11545

Add extended woff2 files in Source Sans Pro
ClosedPublic
Actions

Authored by chad on Jan 28 2015, 9:02 PM.
Tags
None
Referenced Files
F14124710: D11545.id27788.diff
Sat, Nov 30, 4:33 AM
Unknown Object (File)
Wed, Nov 27, 4:38 AM
Unknown Object (File)
Sat, Nov 23, 1:12 PM
Unknown Object (File)
Tue, Nov 19, 2:35 PM
Unknown Object (File)
Fri, Nov 15, 6:30 AM
Unknown Object (File)
Mon, Nov 11, 1:48 PM
Unknown Object (File)
Thu, Nov 7, 4:37 AM
Unknown Object (File)
Fri, Nov 1, 7:47 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7066: Phriction documents looks horrible on Firefox
Commits
Restricted Diffusion Commit
rP958e5c638927: Add extended woff2 files in Source Sans Pro
Summary

Builds a complete font package for browsers that support woff2. Ref T7066

Test Plan

Visit a test page locally with addtional languages.

Diff Detail

Repository
rP Phabricator
Branch
Source-Sans
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/css/font/font-source-sans-pro.css:11TXT3Line Too Long
Warningwebroot/rsrc/css/font/font-source-sans-pro.css:21TXT3Line Too Long
Warningwebroot/rsrc/css/font/font-source-sans-pro.css:22TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 4135
Build 4148: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27788.Jan 28 2015, 9:02 PM
chad retitled this revision from to Add extended woff2 files in Source Sans Pro.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T7066: Phriction documents looks horrible on Firefox.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 28 2015, 9:02 PM
chad mentioned this in T7066: Phriction documents looks horrible on Firefox.Jan 28 2015, 9:02 PM
chad updated this revision to Diff 27789.Jan 28 2015, 9:06 PM
  • Properly link woff2 files
epriestley requested changes to this revision.Jan 28 2015, 9:06 PM
epriestley edited edge metadata.

You should specify the URL()'s without quotes. The rewriter isn't smart enough to figure them out.

This revision now requires changes to proceed.Jan 28 2015, 9:06 PM
chad updated this revision to Diff 27790.Jan 28 2015, 9:09 PM
chad edited edge metadata.
  • Fix quotes
epriestley accepted this revision.Jan 28 2015, 9:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 9:12 PM
Closed by commit rP958e5c638927: Add extended woff2 files in Source Sans Pro (authored by chad, committed by chad). · Explain WhyJan 28 2015, 9:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
webroot/
rsrc/
css/
font/
8 lines
externals/
font/
sourcesans/

Diff 27790

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/font/font-source-sans-pro.css

Loading...
View Options

webroot/rsrc/externals/font/sourcesans/SourceSansPro-Bold.woff2

Loading...
View Options

webroot/rsrc/externals/font/sourcesans/SourceSansPro-Regular.woff2

Loading...
Phabricator · Built by Phacility