Make grammar more consistent
ClosedPublic
Actions

Authored by epriestley on Jan 28 2015, 8:51 PM.

Tags

None

Referenced Files

	F14375166: D11544.diff
	Fri, Dec 20, 10:00 PM

	F14366159: D11544.diff
	Fri, Dec 20, 3:09 PM

	Unknown Object (File)
	Thu, Dec 19, 6:57 AM

	Unknown Object (File)
	Sun, Dec 8, 1:38 AM

	Unknown Object (File)
	Sat, Dec 7, 10:49 PM

	Unknown Object (File)
	Nov 19 2024, 1:54 AM

	Unknown Object (File)
	Nov 16 2024, 6:10 PM

	Unknown Object (File)
	Nov 2 2024, 12:14 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP6a0fb7c37f3f: Make grammar more consistent

Summary

In Maniphest, we say "X closed <task> by committing <commit>". In Differential, we currently say "X closed <revision> by commit <commit>", which sounds nongrammatical to me.

Test Plan

grammar'd

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27785.Jan 28 2015, 8:51 PM

epriestley retitled this revision from to Make grammar more consistent.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 28 2015, 8:51 PM

chad accepted this revision.Jan 28 2015, 8:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 28 2015, 8:52 PM

Closed by commit rP6a0fb7c37f3f: Make grammar more consistent (authored by epriestley, committed by epriestley). · Explain WhyJan 28 2015, 8:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialTransaction.php

4 lines

Diff 27786

View Options

src/applications/differential/storage/DifferentialTransaction.php

Make grammar more consistentClosedPublicActions