Page MenuHomePhabricator
Differential D11544

Make grammar more consistent
ClosedPublic
Actions

Authored by epriestley on Jan 28 2015, 8:51 PM.
Tags
None
Referenced Files
F13330976: D11544.diff
Mon, Jun 17, 5:20 AM
F13323374: D11544.diff
Fri, Jun 14, 5:16 PM
F13318110: D11544.diff
Thu, Jun 13, 10:15 AM
F13303695: D11544.diff
Sat, Jun 8, 7:07 AM
F13288664: D11544.diff
Tue, Jun 4, 10:45 AM
F13254385: D11544.diff
Sat, May 25, 3:22 AM
F13250327: D11544.diff
Fri, May 24, 2:02 PM
F13236929: D11544.id27785.diff
Tue, May 21, 11:35 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP6a0fb7c37f3f: Make grammar more consistent
Summary

In Maniphest, we say "X closed <task> by committing <commit>". In Differential, we currently say "X closed <revision> by commit <commit>", which sounds nongrammatical to me.

Test Plan

grammar'd

Diff Detail

Repository
rP Phabricator
Branch
cgramar
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4131
Build 4144: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27785.Jan 28 2015, 8:51 PM
epriestley retitled this revision from to Make grammar more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 28 2015, 8:51 PM
chad accepted this revision.Jan 28 2015, 8:52 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 8:52 PM
Closed by commit rP6a0fb7c37f3f: Make grammar more consistent (authored by epriestley, committed by epriestley). · Explain WhyJan 28 2015, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
4 lines

Diff 27785

View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
Phabricator · Built by Phacility