Page MenuHomePhabricator

Make grammar more consistent
ClosedPublic

Authored by epriestley on Jan 28 2015, 8:51 PM.
Tags
None
Referenced Files
F13323374: D11544.diff
Fri, Jun 14, 5:16 PM
F13318110: D11544.diff
Thu, Jun 13, 10:15 AM
F13303695: D11544.diff
Sat, Jun 8, 7:07 AM
F13288664: D11544.diff
Tue, Jun 4, 10:45 AM
F13254385: D11544.diff
Sat, May 25, 3:22 AM
F13250327: D11544.diff
Fri, May 24, 2:02 PM
F13236929: D11544.id27785.diff
Tue, May 21, 11:35 AM
F13233645: D11544.diff
Tue, May 21, 2:28 AM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP6a0fb7c37f3f: Make grammar more consistent
Summary

In Maniphest, we say "X closed <task> by committing <commit>". In Differential, we currently say "X closed <revision> by commit <commit>", which sounds nongrammatical to me.

Test Plan

grammar'd

Diff Detail

Repository
rP Phabricator
Branch
cgramar
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4131
Build 4144: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make grammar more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 8:52 PM
This revision was automatically updated to reflect the committed changes.