Page MenuHomePhabricator
Differential D11544

Make grammar more consistent
ClosedPublic
Actions

Authored by epriestley on Jan 28 2015, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:57 PM
Unknown Object (File)
Sat, Feb 8, 1:47 AM
Unknown Object (File)
Sat, Feb 8, 1:47 AM
Unknown Object (File)
Sat, Feb 8, 1:46 AM
Unknown Object (File)
Sat, Feb 8, 1:46 AM
Unknown Object (File)
Wed, Jan 29, 11:22 PM
Unknown Object (File)
Fri, Jan 24, 8:48 AM
Unknown Object (File)
Thu, Jan 23, 10:59 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rP6a0fb7c37f3f: Make grammar more consistent
Summary

In Maniphest, we say "X closed <task> by committing <commit>". In Differential, we currently say "X closed <revision> by commit <commit>", which sounds nongrammatical to me.

Test Plan

grammar'd

Diff Detail

Repository
rP Phabricator
Branch
cgramar
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4131
Build 4144: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27785.Jan 28 2015, 8:51 PM
epriestley retitled this revision from to Make grammar more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 28 2015, 8:51 PM
chad accepted this revision.Jan 28 2015, 8:52 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2015, 8:52 PM
Closed by commit rP6a0fb7c37f3f: Make grammar more consistent (authored by epriestley, committed by epriestley). · Explain WhyJan 28 2015, 8:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
4 lines

Diff 27785

View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
Phabricator · Built by Phacility