Use x.y in favor of x['y'] in some JavaScript callsites. Note that there are a bunch of places where the latter is explicitly used to trick PhabricatorJavelinLinter.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPdd81268a8e4f: Use dot notation in some places
arc lint
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4123 Build 4136: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
The JX.* stuff is supposedly evading symbol stuff, but if it's not firing you can just land this.
I think T1549 is the real fix for this kind of issue anyway (i.e., annotate explicitly with a comment), not "trick the static analyzer".
Maybe remove the comments about evading static analysis, though.
| webroot/rsrc/externals/javelin/core/Event.js | ||
|---|---|---|
| 226–227 ↗ | (On Diff #27703) | My expectation is that this will mask a different lint error ("file does not declare dependency on JX.Stratcom, but uses symbol"). Not sure why that's not firing. |
| webroot/rsrc/externals/javelin/core/init.js | ||
| 60–61 | As above. | |
| webroot/rsrc/externals/javelin/ext/reactor/core/Reactor.js | ||
| 85–86 ↗ | (On Diff #27703) | These might be trying to "weak bind" to avoid a circular dependency. |