Add a setBorder call to CrumbsView to be more deliberate when a border is drawn. Could not find any CSS hacks to set it conditionally CSS.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rP170dc15c05cb: Make border conditional in crumbs
Browsed every application that called crumbs and make a design decision. Also fixed a few bad layouts.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- crumbies
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4105 Build 4118: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
When does one setBorder(true) vs setBorder(false) ? Maybe its in the uiexample already?
Comment Actions
It's a pattern that I can't imagine can be made into a UIExample. Basically I want to not have a double horizontal rule that's taking up 98% of the top of the page width.
Comment Actions
I'd vaguely like to fix these pages (most/all of which seem unusual/inconsistent in some way) eventually, but am fine with this until we get around to that.